lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] dt-bindings: phy: rcar-gen3-phy-usb2: add r8a77961 support
Hi Shimoda-san,

On Wed, Mar 25, 2020 at 7:18 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> This patch adds support for r8a77961 (R-Car M3-W+).
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> @@ -18,6 +18,8 @@ Required properties:
> SoC.
> "renesas,usb2-phy-r8a7796" if the device is a part of an R8A7796

While at it, you may want to update "r8A7796 SoC" to "r8A77960 SoC", to
avoid confusion between R-Car M3-W (R8A77960) and M3-W+ (R8A77961).

Note that rebasing this patch on top of your "[PATCH v2] dt-bindings:
phy: renesas: usb2-phy: convert bindings to json-schema"
(https://lore.kernel.org/linux-devicetree/1572592763-12396-1-git-send-email-yoshihiro.shimoda.uh@renesas.com/)
would avoid that, too.

> SoC.
> + "renesas,usb2-phy-r8a77961" if the device is a part of an
> + R8A77961 SoC.
> "renesas,usb2-phy-r8a77965" if the device is a part of an
> R8A77965 SoC.
> "renesas,usb2-phy-r8a77990" if the device is a part of an

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2020-03-25 14:06    [W:0.050 / U:4.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site