lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V8 5/9] vDPA: introduce vDPA bus
On Wed, Mar 25, 2020 at 04:27:07PM +0800, Jason Wang wrote:
> +struct vdpa_device *__vdpa_alloc_device(struct device *parent,
> + const struct vdpa_config_ops *config,
> + size_t size);
> +
> +#define vdpa_alloc_device(dev_struct, member, parent, config) \
> + container_of(__vdpa_alloc_device( \
> + parent, config, \
> + sizeof(struct dev_struct) + \
> + BUILD_BUG_ON_ZERO(offsetof( \
> + struct dev_struct, member))), \
> + struct dev_struct, member)

This all looks robust now, one minor remark is to not do 'struct
dev_struct' here so the caller has to do

vdpa_alloc_device(struct foo, vpda, ...)

Which suggests to the reader something unusual is happening

Jason

\
 
 \ /
  Last update: 2020-03-25 13:30    [W:0.780 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site