Messages in this thread Patch in this message | | | Date | Wed, 25 Mar 2020 12:06:01 -0000 | From | "tip-bot2 for Qais Yousef" <> | Subject | [tip: smp/core] xen/cpuhotplug: Replace cpu_up/down() with device_online/offline() |
| |
The following commit has been merged into the smp/core branch of tip:
Commit-ID: a926f81d2f6c51458e116c5b3ff3af471b56098f Gitweb: https://git.kernel.org/tip/a926f81d2f6c51458e116c5b3ff3af471b56098f Author: Qais Yousef <qais.yousef@arm.com> AuthorDate: Mon, 23 Mar 2020 13:51:06 Committer: Thomas Gleixner <tglx@linutronix.de> CommitterDate: Wed, 25 Mar 2020 12:59:36 +01:00
xen/cpuhotplug: Replace cpu_up/down() with device_online/offline()
The core device API performs extra housekeeping bits that are missing from directly calling cpu_up/down().
See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and serialization during LPM") for an example description of what might go wrong.
This also prepares to make cpu_up/down() a private interface of the cpu subsystem.
Signed-off-by: Qais Yousef <qais.yousef@arm.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Juergen Gross <jgross@suse.com> Link: https://lkml.kernel.org/r/20200323135110.30522-14-qais.yousef@arm.com
--- drivers/xen/cpu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c index f192b6f..ec975de 100644 --- a/drivers/xen/cpu_hotplug.c +++ b/drivers/xen/cpu_hotplug.c @@ -94,7 +94,7 @@ static int setup_cpu_watcher(struct notifier_block *notifier, for_each_possible_cpu(cpu) { if (vcpu_online(cpu) == 0) { - (void)cpu_down(cpu); + device_offline(get_cpu_device(cpu)); set_cpu_present(cpu, false); } }
| |