lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH v2] iio: buffer: Don't allow buffers without any channels enabled to be activated
Date
On Wed, 2020-03-25 at 12:01 +0200, Alexandru Ardelean wrote:
> From: Lars-Peter Clausen <lars@metafoo.de>
>
> Before activating a buffer make sure that at least one channel is enabled.
> Activating a buffer with 0 channels enabled doesn't make too much sense and
> disallowing this case makes sure that individual driver don't have to add
> special case code to handle it.
>

oops, i goof-ed peter's email on this send;
[ copy + paste err ]
should be fixed now;

> Currently, without this patch enabling a buffer is possible and no error is
> produced. With this patch -EINVAL is returned.
>
> An example of execution with this patch and some instrumented print-code:
> root@analog:~# cd /sys/bus/iio/devices/iio\:device3/buffer
> root@analog:/sys/bus/iio/devices/iio:device3/buffer# echo 1 > enable
> 0: iio_verify_update 748 indio_dev->masklength 2 *insert_buffer->scan_mask
> 00000000
> 1: iio_verify_update 753
> 2:__iio_update_buffers 1115 ret -22
> 3: iio_buffer_store_enable 1241 ret -22
> -bash: echo: write error: Invalid argument
> 1, 2 & 3 are exit-error paths. 0 the first print in iio_verify_update()
> rergardless of error path.
>
> Without this patch (and same instrumented print-code):
> root@analog:~# cd /sys/bus/iio/devices/iio\:device3/buffer
> root@analog:/sys/bus/iio/devices/iio:device3/buffer# echo 1 > enable
> 0: iio_verify_update 748 indio_dev->masklength 2 *insert_buffer->scan_mask
> 00000000
> root@analog:/sys/bus/iio/devices/iio:device3/buffer#
> Buffer is enabled with no error.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
>
> Changelog v1 -> v2:
> * moved check in iio_verify_update()
> * added dev_dbg() message; should help some folks understand the message
> * documented steps to reproduce
> * added Fixes tag; hopefully the tag is the good one; if needed, it can be
> dropped; this has been around for ~8 years; no idea if it's worth
> backporting
>
> drivers/iio/industrialio-buffer.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-
> buffer.c
> index 5ff34ce8b6a2..e6fa1a4e135d 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -686,6 +686,13 @@ static int iio_verify_update(struct iio_dev *indio_dev,
> bool scan_timestamp;
> unsigned int modes;
>
> + if (insert_buffer &&
> + bitmap_empty(insert_buffer->scan_mask, indio_dev->masklength)) {
> + dev_dbg(&indio_dev->dev,
> + "At least one scan element must be enabled first\n");
> + return -EINVAL;
> + }
> +
> memset(config, 0, sizeof(*config));
> config->watermark = ~0;
>
\
 
 \ /
  Last update: 2020-03-25 11:14    [W:0.077 / U:3.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site