lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3 03/11] pstore/blk: respect for driver to pick pstore front-ends
Date
For most devices, not all psotre front-ends are supported. Pstore/blk
should provide a way for drivers to list the supported front-ends.

Signed-off-by: WeiXiong Liao <liaoweixiong@allwinnertech.com>
---
fs/pstore/pstore_blk.c | 18 ++++++++++++++----
include/linux/pstore_blk.h | 4 +++-
2 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/fs/pstore/pstore_blk.c b/fs/pstore/pstore_blk.c
index 2fbdd4563e5c..f3ce7bbd9077 100644
--- a/fs/pstore/pstore_blk.c
+++ b/fs/pstore/pstore_blk.c
@@ -65,6 +65,9 @@
*
* @total_size: The total size in bytes pstore/blk can use. It must be greater
* than 4096 and be multiple of 4096.
+ * @flags: Refer to macro starting with PSTORE_FLAGS defined in
+ * linux/pstore.h. It means what front-ends this device support.
+ * Zero means all recorders for compatible.
* @read: The general read operation. Both of the function parameters
* @size and @offset are relative value to bock device (not the
* whole disk).
@@ -77,6 +80,7 @@
*/
struct psblk_device {
unsigned long total_size;
+ unsigned int flags;
psz_read_op read;
psz_write_op write;
psz_write_op panic_write;
@@ -102,8 +106,11 @@ static int psblk_register_do(struct psblk_device *dev)
return -ENOMEM;
}

-#define verify_size(name, alignsize) { \
- long _##name_ = (name); \
+ /* zero means all recorders for compatible */
+ if (!dev->flags)
+ dev->flags = UINT_MAX;
+#define verify_size(name, alignsize, enable) { \
+ long _##name_ = (enable) ? (name) : 0; \
_##name_ = _##name_ <= 0 ? 0 : (_##name_ * 1024); \
if (_##name_ & ((alignsize) - 1)) { \
pr_info(#name " must align to %d\n", \
@@ -114,7 +121,7 @@ static int psblk_register_do(struct psblk_device *dev)
psz_info->name = _##name_; \
}

- verify_size(oops_size, 4096);
+ verify_size(oops_size, 4096, dev->flags & PSTORE_FLAGS_DMESG);
#undef verify_size
dump_oops = dump_oops <= 0 ? 0 : 1;

@@ -311,6 +318,7 @@ static struct bdev_info *psblk_get_bdev_info(void)
* psblk_register_blkdev() - register block device to pstore/blk
*
* @major: the major device number of registering device
+ * @flags: refer to macro starting with PSTORE_FLAGS defined in linux/pstore.h
* @panic_write: the interface for panic case.
*
* Only the matching major to @blkdev can register.
@@ -321,7 +329,8 @@ static struct bdev_info *psblk_get_bdev_info(void)
* * 0 - OK
* * Others - something error.
*/
-int psblk_register_blkdev(unsigned int major, psblk_panic_write_op panic_write)
+int psblk_register_blkdev(unsigned int major, unsigned int flags,
+ psblk_panic_write_op panic_write)
{
struct block_device *bdev;
struct psblk_device dev = {0};
@@ -352,6 +361,7 @@ int psblk_register_blkdev(unsigned int major, psblk_panic_write_op panic_write)
blkdev_panic_write = panic_write;

dev.total_size = psblk_bdev_size(bdev);
+ dev.flags = flags;
dev.panic_write = panic_write ? psblk_blk_panic_write : NULL;
dev.read = psblk_generic_blk_read;
dev.write = psblk_generic_blk_write;
diff --git a/include/linux/pstore_blk.h b/include/linux/pstore_blk.h
index 5ff465e3953e..d8f609e60288 100644
--- a/include/linux/pstore_blk.h
+++ b/include/linux/pstore_blk.h
@@ -4,6 +4,7 @@
#define __PSTORE_BLK_H_

#include <linux/types.h>
+#include <linux/pstore.h>
#include <linux/pstore_zone.h>

/**
@@ -20,7 +21,8 @@
typedef int (*psblk_panic_write_op)(const char *buf, sector_t start_sect,
sector_t sects);

-int psblk_register_blkdev(unsigned int major, psblk_panic_write_op panic_write);
+int psblk_register_blkdev(unsigned int major, unsigned int flags,
+ psblk_panic_write_op panic_write);
void psblk_unregister_blkdev(unsigned int major);
int psblk_blkdev_info(dev_t *devt, sector_t *nr_sects, sector_t *start_sect);

--
1.9.1
\
 
 \ /
  Last update: 2020-03-25 09:56    [W:0.053 / U:32.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site