lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success
From
Date
On 2020/3/25 6:06, Miquel Raynal wrote:
> Hi Xiaoming,
>
> Xiaoming Ni <nixiaoming@huawei.com> wrote on Fri, 20 Mar 2020 11:15:11
> +0800:
>
>> mtdblock_flush()
>> -->write_cached_data()
>> --->erase_write()
>> mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed
>>
>> Because mtdblock_flush() always returns 0,
>> even if write_cached_data() fails and data is not written to the device,
>> syscall_write() still returns success
>
> I reworded a bit the commit log and also added a ' ' after 'mtd:' in
> the title when applying.
>
> Thanks,
> Miquèl

Your revised commit log is more accurate and clearer, thanks for your
correction
Thanks.
Xiaoming Ni


\
 
 \ /
  Last update: 2020-03-25 08:55    [W:0.038 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site