Messages in this thread | | | Subject | Re: [PATCH v2 1/3] dt-bindings: sound: convert rockchip spdif bindings to yaml | From | Johan Jonker <> | Date | Tue, 24 Mar 2020 14:41:45 +0100 |
| |
Hi Mark,
Today I send 2 sets. One for I2S and one for SPDIF. 'power-domains' is added in respons to robh answer to rockchip,vop.txt conversion.
>> Hi, >> >> Question for robh: >> >> In the old txt situation we add/describe only properties that are used >> by the driver/hardware itself. With yaml it also filters things in a >> node that are used by other drivers like: >> >> assigned-clocks: >> assigned-clock-rates: >> power-domains: >> >> Should we add or not? > > Yes, only pinctrl properties are automatically added. > > We could change 'assigned-clocks', but for now I think they should be > added. > > Rob
On 3/24/20 2:35 PM, Mark Brown wrote: > On Tue, Mar 24, 2020 at 01:31:53PM +0100, Johan Jonker wrote: >> Current dts files with 'spdif' nodes are manually verified. >> In order to automate this process rockchip-spdif.txt >> has to be converted to yaml. > >> Signed-off-by: Johan Jonker <jbx6244@gmail.com> >> --- >> Changed V2: >> dmas and dma-names layout > > This is the second v2 you've sent of this today - it adds these but > drops Rob's ack? >
| |