lkml.org 
[lkml]   [2020]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] arm64: clean up trampoline vector loads
    On Tue, Mar 24, 2020 at 10:52:17AM +0000, Mark Rutland wrote:
    > On Mon, Mar 23, 2020 at 10:42:30PM +0200, Rémi Denis-Courmont wrote:
    > > Le maanantaina 23. maaliskuuta 2020, 21.04.09 EET Catalin Marinas a écrit :
    > > > Should we just use adrp on __entry_tramp_data_start? Anyway, the diff
    > > > below doesn't solve the issue I'm seeing (only reverting patch 3).
    > >
    > > AFAIU, the preexisting code uses the manual PAGE_SIZE offset because the offset
    > > in the main vmlinux does not match the architected offset inside the fixmap. If
    > > so, then using the symbol directly will not work at all.
    >
    > Indeed. I can't see a neat way of avoiding this right now, so should we
    > drop these patches and leave the code as-is (but with comments as to the
    > special requirements that it has)?

    I'm going to drop these three patches from -next for now but I can take
    any updated comments (they are pretty much missing from this code).

    Thanks.

    --
    Catalin

    \
     
     \ /
      Last update: 2020-03-24 12:24    [W:3.164 / U:0.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site