Messages in this thread Patch in this message | | | Date | Tue, 24 Mar 2020 11:07:10 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function |
| |
On Fri, 20 Mar 2020, Lee Jones wrote:
> On Thu, 19 Mar 2020, Guru Das Srinagesh wrote: > > > Since the PWM framework is switching struct pwm_state.period's datatype > > to u64, prepare for this transition by using div_u64 to handle a 64-bit > > dividend instead of a straight division operation. > > > > Cc: Lee Jones <lee.jones@linaro.org> > > Cc: Daniel Thompson <daniel.thompson@linaro.org> > > Cc: Jingoo Han <jingoohan1@gmail.com> > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > Cc: linux-pwm@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-fbdev@vger.kernel.org > > > > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > --- > > drivers/video/backlight/pwm_bl.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Can this patch be taken on its own?
Hellooooo ...
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > > index efb4efc..3e5dbcf 100644 > > --- a/drivers/video/backlight/pwm_bl.c > > +++ b/drivers/video/backlight/pwm_bl.c > > @@ -625,7 +625,8 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->scale = data->max_brightness; > > } > > > > - pb->lth_brightness = data->lth_brightness * (state.period / pb->scale); > > + pb->lth_brightness = data->lth_brightness * (div_u64(state.period, > > + pb->scale)); > > > > props.type = BACKLIGHT_RAW; > > props.max_brightness = data->max_brightness; >
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |