Messages in this thread | | | Date | Mon, 23 Mar 2020 21:52:51 -0700 (PDT) | Subject | Re: [PATCH net v2] ethtool: fix reference leak in some *_SET handlers | From | David Miller <> |
| |
From: Michal Kubecek <mkubecek@suse.cz> Date: Sun, 22 Mar 2020 22:24:21 +0100 (CET)
> Andrew noticed that some handlers for *_SET commands leak a netdev > reference if required ethtool_ops callbacks do not exist. A simple > reproducer would be e.g. > > ip link add veth1 type veth peer name veth2 > ethtool -s veth1 wol g > ip link del veth1 > > Make sure dev_put() is called when ethtool_ops check fails. > > v2: add Fixes tags > > Fixes: a53f3d41e4d3 ("ethtool: set link settings with LINKINFO_SET request") > Fixes: bfbcfe2032e7 ("ethtool: set link modes related data with LINKMODES_SET request") > Fixes: e54d04e3afea ("ethtool: set message mask with DEBUG_SET request") > Fixes: 8d425b19b305 ("ethtool: set wake-on-lan settings with WOL_SET request") > Reported-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Michal Kubecek <mkubecek@suse.cz> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Applied, thanks Michal.
| |