Messages in this thread | | | Subject | Re: [PATCH] kthread: Mark timer used by delayed kthread works as IRQ safe | From | Grygorii Strashko <> | Date | Tue, 24 Mar 2020 12:46:41 +0200 |
| |
Hi All,
On 16/03/2020 14:23, Grygorii Strashko wrote: > Hi Petr, > > On 19/02/2020 17:22, Tejun Heo wrote: >> On Mon, Feb 17, 2020 at 01:07:09PM +0100, Petr Mladek wrote: >>> The timer used by delayed kthread works are IRQ safe because the used >>> kthread_delayed_work_timer_fn() is IRQ safe. >>> >>> It is properly marked when initialized by KTHREAD_DELAYED_WORK_INIT(). >>> But TIMER_IRQSAFE flag is missing when initialized by >>> kthread_init_delayed_work(). >>> >>> The missing flag might trigger invalid warning from del_timer_sync() >>> when kthread_mod_delayed_work() is called with interrupts disabled. >>> >>> Reported-by: Grygorii Strashko <grygorii.strashko@ti.com> >>> Signed-off-by: Petr Mladek <pmladek@suse.com> >>> Tested-by: Grygorii Strashko <grygorii.strashko@ti.com> >> >> Acked-by: Tejun Heo <tj@kernel.org> > > I'm worry shouldn't this patch have "fixes" tag? >
Sorry, the I'm disturbing you, but I have dependency from this path [1]. I can see it in -next: commit d7c8c7de96de ("kthread: mark timer used by delayed kthread works as IRQ safe"), but it does not present in net-next.
Any way this can be resolved?
[1] https://patchwork.ozlabs.org/cover/1259207/ -- Best regards, grygorii
| |