Messages in this thread | | | Date | Tue, 24 Mar 2020 11:19:38 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] coresight: do not use the BIT() macro in the UAPI header |
| |
On Tue, Mar 24, 2020 at 10:53:04AM +0100, Eugene Syromiatnikov wrote: > On Tue, Mar 24, 2020 at 07:28:53AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Mar 24, 2020 at 05:22:13AM +0100, Eugene Syromiatnikov wrote: > > > The BIT() macro definition is not available for the UAPI headers > > > (moreover, it can be defined differently in the user space); replace > > > its usage with the _BITUL() macro that is defined in <linux/const.h>. > > > > Why is somehow _BITUL() ok to use here instead? > > It is provided in an UAPI header (include/uapi/linux/const.h) > and is appropriately prefixed with an underscore to avoid conflicts.
Because no one uses _ in their own macros? :)
Anyway, this is fine, but if it's really the way forward, I think a lot of files will end up being changed...
thanks,
greg k-h
| |