Messages in this thread | | | Subject | Re: [PATCH] f2fs: remove redundant compress inode check | From | Chao Yu <> | Date | Wed, 25 Mar 2020 09:26:05 +0800 |
| |
On 2020/3/24 23:43, Jaegeuk Kim wrote: > On 03/24, Chao Yu wrote: >> Jaegeuk, >> >> Missed to apply this patch? >> >> On 2020/2/29 18:49, Chao Yu wrote: >>> due to f2fs_post_read_required() has did that. >>> >>> Signed-off-by: Chao Yu <yuchao0@huawei.com> >>> --- >>> fs/f2fs/f2fs.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >>> index f4bcbbd5e9ed..882f9ad3445b 100644 >>> --- a/fs/f2fs/f2fs.h >>> +++ b/fs/f2fs/f2fs.h >>> @@ -4006,8 +4006,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode, >>> return true; >>> if (f2fs_is_multi_device(sbi)) >>> return true; >>> - if (f2fs_compressed_file(inode)) >>> - return true; > > I thought that we can keep this to avoid any confusion when porting to old > production kernel which uses ICE.
That old kernel w/ ICE doesn't have f2fs_post_read_required(), right?
I thought we backport features with order of the time fsverity/compression feature was introduced, then f2fs_post_read_required() should be there when we backport compression feature.
Thanks,
> >>> /* >>> * for blkzoned device, fallback direct IO to buffered IO, so >>> * all IOs can be serialized by log-structured write. >>> > . >
| |