Messages in this thread | | | Date | Tue, 24 Mar 2020 20:38:34 +0000 | From | Mark Brown <> | Subject | Re: [PATCH V4 11/13] dt-bindings: regulator: add DVFSRC regulator dt-bindings |
| |
On Fri, Mar 13, 2020 at 05:34:24PM +0800, Henry Chen wrote:
> +- regulator : The DVFSRC regulator is modelled as a subdevice of the DVFSRC. > + Because DVFSRC can request power directly via register read/write, likes > + vcore which is a core power of mt8183. As such, the DVFSRC regulator > + requires that DVFSRC nodes be present. shall contain only one of the > + following: "mediatek,mt8183-dvfsrc-regulator"
Why do we even need a compatible here - it's not adding any new information to the parent mt8183 node, the compatible is mainly for the way Linux divides things up rather than a description of the hardware. We could just say that the regulator node always has a particular name instead.
It's also not quite true that it contains "only" the compatible - it also allows the regulator constraints to be defined. [unhandled content-type:application/pgp-signature] | |