Messages in this thread | | | From | Nick Desaulniers <> | Date | Tue, 24 Mar 2020 10:33:32 -0700 | Subject | Re: [PATCH 11/16] x86: probe assembler capabilities via kconfig instead of makefile |
| |
On Tue, Mar 24, 2020 at 10:17 AM Jason A. Donenfeld <Jason@zx2c4.com> wrote: > > On Tue, Mar 24, 2020 at 11:01 AM Nick Desaulniers > <ndesaulniers@google.com> wrote: > > > > Can 11 just be rebased with 8 dropped? > > 8 adds comments to one place. 11 moves them to another place, while > doing other things. > > Your desire is to skip the first step? I guess there's no problem with > this, but I'm curious to learn why.
Before this series, there's no comments. After, the comments are in arch/x86/Kconfig.assembler. Don't waste reviewers time by having other patches in the set that move them around for fun. Just add them to the final destination.
-- Thanks, ~Nick Desaulniers
| |