Messages in this thread | | | Date | Mon, 23 Mar 2020 20:38:37 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 5/6] gpio: dwapb: Add debounce reference clock support |
| |
On Mon, Mar 23, 2020 at 09:06:31PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > From: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Aside from the APB reference clock DW GPIO controller can have a > dedicated clock connected to setup a debounce time interval for > GPIO-based IRQs. Since this functionality is optional the corresponding > clock source is also optional. Due to this lets handle the debounce > clock in the same way as it has been developed for the APB reference > clock, but using the bulk request/enable-disable methods.
> + if (err) { > + dev_err(gpio->dev, "Cannot reenable APB/Debounce clocks\n"); > + return err; > + }
Yeah, this should be a separate change.
Otherwise looks good.
Also, did I miss the documentation update (bindings)?
-- With Best Regards, Andy Shevchenko
| |