Messages in this thread | | | Subject | Re: lockdep warning in urb.c:363 usb_submit_urb | From | Oliver Neukum <> | Date | Mon, 23 Mar 2020 17:18:00 +0100 |
| |
Am Montag, den 23.03.2020, 11:54 -0400 schrieb Alan Stern: > On Mon, 23 Mar 2020, Oliver Neukum wrote: > > > Am Montag, den 23.03.2020, 14:38 +0000 schrieb Qais Yousef: > > > Hi > > > > > > I've hit the following lockdep warning when I trigger hibernate on arm64 > > > platform (Juno-r2) > > > > > > > > > echo suspend > /sys/power/disk > > > echo disk > /sys/power/state > > > > > > I only had a usb flash drive attached to it. Let me know if you need more info. > > > > Hi, > > > > that is not a lockdep issue, but the hub driver is not properly killing > > its URB presumably. Yet, the driver looks correct to me. Please use > > the additional patch and activate dynamic debugging for usbcore. > > Was the USB flash drive being used as a swap device for holding the > hibernation image? That's not likely to work very well. At least, I > doubt that it has been tested very much.
Right, but this is good. We are getting a test for something that needs work. It does not really matetr why STD fails.
> This diagnostic was suggested by the runtime PM error that occurred > when the system was trying to store the hibernation image. That's > probably when the hub driver's URB got restarted.
AFAICT hub_quiesce() unconditionally calls usb_kill_urb(). So I'd like to verify that case is really triggered.
Regards Oliver
| |