Messages in this thread | | | Date | Mon, 23 Mar 2020 15:55:22 +0100 | From | Roger Pau Monné <> | Subject | Re: [PATCH v2] xen-pciback: fix INTERRUPT_TYPE_* defines |
| |
On Fri, Mar 20, 2020 at 04:09:18AM +0100, Marek Marczykowski-Górecki wrote: > xen_pcibk_get_interrupt_type() assumes INTERRUPT_TYPE_NONE being 0 > (initialize ret to 0 and return as INTERRUPT_TYPE_NONE). > Fix the definition to make INTERRUPT_TYPE_NONE really 0, and also shift > other values to not leave holes. > But also, do not assume INTERRUPT_TYPE_NONE being 0 anymore to avoid > similar confusions in the future. > > Fixes: 476878e4b2be ("xen-pciback: optionally allow interrupt enable flag writes") > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
| |