lkml.org 
[lkml]   [2020]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] coresight: etm4x: Add support for Qualcomm SC7180 SoC
Hi Suzuki,

On 2020-03-23 15:25, Suzuki K Poulose wrote:
> On 03/20/2020 07:44 AM, Sai Prakash Ranjan wrote:
>> Add ETM Peripheral IDs for Qualcomm SC7180 SoC. It has
>> 2 big CPU cores based on Cortex-A76 and 6 LITTLE CPU
>> cores based on Cortex-A55.
>>
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>> drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c
>> b/drivers/hwtracing/coresight/coresight-etm4x.c
>> index a90d757f7043..a153a65c4c5b 100644
>> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
>> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
>> @@ -1556,6 +1556,8 @@ static const struct amba_id etm4_ids[] = {
>> CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
>> CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */
>> CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */
>> + CS_AMBA_ID(0x000bb805), /* Qualcomm Kryo 4XX Cortex-A55 */
>> + CS_AMBA_ID(0x000bb804), /* Qualcomm Kryo 4XX Cortex-A76 */
>
> Does the DEVARCH indicate that it is an ETMv4 ? (It should !) Please
> could we enforce the UCI_ID check for these components ? The
> moment you add CTI components to your board this could conflict with
> them unless we check the UCI_ID for ETMv4.
>

Yes I got these IDs through devarch and it does indicate that it is
ETMv4.2.

devname=7040000.etm dev->type=0x13 devarch=0x47724a13
devname=7140000.etm dev->type=0x13 devarch=0x47724a13
devname=7240000.etm dev->type=0x13 devarch=0x47724a13
devname=7340000.etm dev->type=0x13 devarch=0x47724a13
devname=7440000.etm dev->type=0x13 devarch=0x47724a13
devname=7540000.etm dev->type=0x13 devarch=0x47724a13
devname=7640000.etm dev->type=0x13 devarch=0x47724a13
devname=7740000.etm dev->type=0x13 devarch=0x47724a13

I will add the UCI_ID as you suggested in next version.

Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation

\
 
 \ /
  Last update: 2020-03-23 12:33    [W:0.041 / U:2.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site