lkml.org 
[lkml]   [2020]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 02/11] arm64: dts: imx8mp: Add AIPS 4 and 5
On 20-03-13 07:44:43, Peng Fan wrote:
> > Subject: [RFC 02/11] arm64: dts: imx8mp: Add AIPS 4 and 5
> >
> > There are 5 AIPS maps in total, according to the RM. Add the missing ones
> > here.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 71b0c8f..a997ca7 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -603,6 +603,22 @@
> > };
> > };
> >
> > + aips4: bus@32c00000 {
> > + compatible = "simple-bus";
>
> "fsl,aips-bus", "simple-bus";
>
> > + reg = <0x32c00000 0x400000>;
>
> Size is 64KB
>
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
> > + };
> > +
> > + aips5: bus@30c00000 {
> > + compatible = "simple-bus";
> > + reg = <0x30c00000 0x400000>;
>
> Ditto. Please correct compatible and reg.
>

Will do in the next version.

> Without this, I think there is no need to only
> add bus here? It might be better to also include
> subnodes under aips bus.

AIPS 5 is needed by the next patch in this series.
So it wouldn't make sense to have a patch that adds
only the fifth one, skipping the fourth one.

>
> Regards,
> Peng.
>
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
> > + };
> > +
> > gic: interrupt-controller@38800000 {
> > compatible = "arm,gic-v3";
> > reg = <0x38800000 0x10000>,
> > --
> > 2.7.4
>

\
 
 \ /
  Last update: 2020-03-23 11:49    [W:0.040 / U:8.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site