Messages in this thread | | | Subject | Re: [PATCH 1/2] coresight: etm4x: Add support for Qualcomm SC7180 SoC | From | Suzuki K Poulose <> | Date | Mon, 23 Mar 2020 09:55:38 +0000 |
| |
On 03/20/2020 07:44 AM, Sai Prakash Ranjan wrote: > Add ETM Peripheral IDs for Qualcomm SC7180 SoC. It has > 2 big CPU cores based on Cortex-A76 and 6 LITTLE CPU > cores based on Cortex-A55. > > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > --- > drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > index a90d757f7043..a153a65c4c5b 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > @@ -1556,6 +1556,8 @@ static const struct amba_id etm4_ids[] = { > CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */ > CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */ > CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */ > + CS_AMBA_ID(0x000bb805), /* Qualcomm Kryo 4XX Cortex-A55 */ > + CS_AMBA_ID(0x000bb804), /* Qualcomm Kryo 4XX Cortex-A76 */
Does the DEVARCH indicate that it is an ETMv4 ? (It should !) Please could we enforce the UCI_ID check for these components ? The moment you add CTI components to your board this could conflict with them unless we check the UCI_ID for ETMv4.
Suzuki
| |