lkml.org 
[lkml]   [2020]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] dts: arm: stih418: Fix complain about IRQ_TYPE_NONE usage
Date
Hi Alain

On 3/22/20 5:16 PM, Alain Volmat wrote:
> Since commit 83a86fbb5b56 ("irqchip/gic: Loudly complain about the use of IRQ_TYPE_NONE")
> kernel is complaining about the IRQ_TYPE_NONE usage which shouldn't
> be used.
>
> Use IRQ_TYPE_LEVEL_HIGH instead.
>
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
> arch/arm/boot/dts/stih418.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih418.dtsi b/arch/arm/boot/dts/stih418.dtsi
> index 83411322bd92..a05e2278b448 100644
> --- a/arch/arm/boot/dts/stih418.dtsi
> +++ b/arch/arm/boot/dts/stih418.dtsi
> @@ -50,7 +50,7 @@
> ohci0: usb@9a03c00 {
> compatible = "st,st-ohci-300x";
> reg = <0x9a03c00 0x100>;
> - interrupts = <GIC_SPI 180 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>;
> resets = <&powerdown STIH407_USB2_PORT0_POWERDOWN>,
> <&softreset STIH407_USB2_PORT0_SOFTRESET>;
> @@ -62,7 +62,7 @@
> ehci0: usb@9a03e00 {
> compatible = "st,st-ehci-300x";
> reg = <0x9a03e00 0x100>;
> - interrupts = <GIC_SPI 151 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 151 IRQ_TYPE_LEVEL_HIGH>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_usb0>;
> clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>;
> @@ -76,7 +76,7 @@
> ohci1: usb@9a83c00 {
> compatible = "st,st-ohci-300x";
> reg = <0x9a83c00 0x100>;
> - interrupts = <GIC_SPI 181 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 181 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>;
> resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>,
> <&softreset STIH407_USB2_PORT1_SOFTRESET>;
> @@ -88,7 +88,7 @@
> ehci1: usb@9a83e00 {
> compatible = "st,st-ehci-300x";
> reg = <0x9a83e00 0x100>;
> - interrupts = <GIC_SPI 153 IRQ_TYPE_NONE>;
> + interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_usb1>;
> clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>;

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

Patrice
\
 
 \ /
  Last update: 2020-03-23 10:18    [W:0.060 / U:7.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site