lkml.org 
[lkml]   [2020]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf test x86: address multiplexing in rdpmc test
On Sat, Mar 21, 2020 at 10:44:49AM -0700, Ian Rogers wrote:
> On Sat, Mar 21, 2020 at 6:41 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Fri, Mar 20, 2020 at 05:14:00PM -0700, Ian Rogers wrote:
> > > Counters may be being used for pinned or other events which inhibit the
> > > instruction counter in the test from being scheduled - time_enabled > 0
> > > but time_running == 0. This causes the test to fail with division by 0.
> > > Add a sleep loop to ensure that the counter is run before computing
> > > the count.

> > > +
> > > + if (running == 0) {
> >
> > This is not in fact the condition the Changelog calls out.
>
> Not sure I follow. As in the multiplexing? It is exactly the condition
> that time_running == 0.

I meant the condition should be 'enabled && !running'.

\
 
 \ /
  Last update: 2020-03-22 10:13    [W:0.030 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site