lkml.org 
[lkml]   [2020]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v7 00/48] atmel_mxt_ts misc
From
Date
Hello Dmitry

On 2020/03/21 0:53, Dmitry Osipenko wrote:
> Hello Jiada,
>
> 20.03.2020 06:37, Wang, Jiada пишет:
>> Hello Dmitry
>>
>> I have submitted v8 patch-set to address your comments towards v7
>> patch-set,
>> most of checkpatch warnings and errors have been addressed,
>>
>> But I didn't update for following two types of warnings
>> since I want to keep consistency with legacy code
>>
>> WARNING: DEVICE_ATTR unusual permissions '0600' used
>> #290: FILE: drivers/input/touchscreen/atmel_mxt_ts.c:3761:
>> +static DEVICE_ATTR(debug_v2_enable, 0600, NULL,
>
> What will happen if you'll use 0644? Will an empty line be returned or
> driver will crash?
>
debug_v2_enable doesn't have .show callback implemented, so after change
permission to 644, read of it results in an I/O error,

for other 0600 permission interfaces (t38_data, t25 and debug_enable)
added in this series,
change to 644 can return expected information when read.

Do you think it's better to change debug_v2_enable to 0200,
and others to 0644?

Thanks,
Jiada

>> WARNING: Consider renaming function(s) 'mxt_debug_notify_show' to
>> 'debug_notify_show'
>> #292: FILE: drivers/input/touchscreen/atmel_mxt_ts.c:3763:
>> +static DEVICE_ATTR(debug_notify, 0444, mxt_debug_notify_show, NULL);
>
> Perhaps this should be fine to ignore, although the prefix is indeed a
> bit superfluous.
>
>> please let me know if you have different view on this
>
> Thank you very much, I'll test v8 during the weekend.
>

\
 
 \ /
  Last update: 2020-03-23 03:27    [W:0.156 / U:5.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site