lkml.org 
[lkml]   [2020]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/2] iio: dac: ad5770r: Add AD5770R support
On Sun, Mar 22, 2020 at 09:17:06AM +0000, Ardelean, Alexandru wrote:
> On Sat, 2020-03-21 at 23:09 +0200, Andy Shevchenko wrote:
> > On Tue, Feb 18, 2020 at 02:10:30PM +0200, Alexandru Tachici wrote:
> > > The AD5770R is a 6-channel, 14-bit resolution, low noise, programmable
> > > current output digital-to-analog converter (DAC) for photonics control
> > > applications.
> > >
> > > It contains five 14-bit resolution current sourcing DAC channels and one
> > > 14-bit resolution current sourcing/sinking DAC channel.
> >
>
> This patch made it into linux-next.
> Doing a v2 now may be a bit noisy.
>
> Maybe we can tidy-this-up later.
> To be honest, it won't be the highest on our list.
> [ I know how that sounds ]

Yes, you may consider a follow up.

> We can probably leave it for other people to clean it up.
> [ People that want to start contributing to the kernel ]

Maybe, but isn't better to supply cleaner code in the first place?

I mean that these comments may be taken into consideration for the future
contributions.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-03-22 23:20    [W:0.063 / U:5.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site