[lkml]   [2020]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net] ethtool: fix reference leak in some *_SET handlers
On Sun, 22 Mar 2020 21:15:51 +0100 (CET) Michal Kubecek wrote:
> Andrew noticed that some handlers for *_SET commands leak a netdev
> reference if required ethtool_ops callbacks do not exist. A simple
> reproducer would be e.g.
> ip link add veth1 type veth peer name veth2
> ethtool -s veth1 wol g
> ip link del veth1
> Make sure dev_put() is called when ethtool_ops check fails.

Fixes: e54d04e3afea ("ethtool: set message mask with DEBUG_SET request")
Fixes: a53f3d41e4d3 ("ethtool: set link settings with LINKINFO_SET request")
Fixes: bfbcfe2032e7 ("ethtool: set link modes related data with LINKMODES_SET request")
Fixes: 8d425b19b305 ("ethtool: set wake-on-lan settings with WOL_SET request")

> Reported-by: Andrew Lunn <>
> Signed-off-by: Michal Kubecek <>

Reviewed-by: Jakub Kicinski <>

 \ /
  Last update: 2020-03-22 21:45    [W:0.044 / U:18.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site