lkml.org 
[lkml]   [2020]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] arm64: dts: rockchip: fix defines in pd_vio node for rk3399
Date
Am Sonntag, 22. März 2020, 17:14:54 CET schrieb Johan Jonker:
> Hi,
>
> Why is 'pd_tcpc0, pd_tcpc1' grouped under 'pd_vio' instead of VD_LOGIC?

^^
You'll need to add Rockchip-people for that - I've done that now ;-)



> On 3/22/20 4:45 PM, Johan Jonker wrote:
> > Hi,
> >
> > The RK3399 TRM uses both
> >
> > 'pd_tcpc0, pd_tcpc1'
> >
> > as
> >
> > 'pd_tcpd0, pd_tcpd1'.
> >
> > What should we use here?

We should probably just fix the nodename as you did.
- For one tcpD seems to be appearing way more often than tcpC
- and of course the header is part of the binding itself, so that shouldn't
change without a really good reason


Heiko

> >
> > Thanks.
> >
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >> index 8aac201f0..3dc8fe620 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >> @@ -1087,12 +1087,12 @@
> >> pm_qos = <&qos_isp1_m0>,
> >> <&qos_isp1_m1>;
> >> };
> >> - pd_tcpc0@RK3399_PD_TCPC0 {
> >> + pd_tcpc0@RK3399_PD_TCPD0 {
> >> reg = <RK3399_PD_TCPD0>;
> >> clocks = <&cru SCLK_UPHY0_TCPDCORE>,
> >> <&cru SCLK_UPHY0_TCPDPHY_REF>;
> >> };
> >> - pd_tcpc1@RK3399_PD_TCPC1 {
> >> + pd_tcpc1@RK3399_PD_TCPD1 {
> >> reg = <RK3399_PD_TCPD1>;
> >> clocks = <&cru SCLK_UPHY1_TCPDCORE>,
> >> <&cru SCLK_UPHY1_TCPDPHY_REF>;
> >
>
>




\
 
 \ /
  Last update: 2020-03-22 19:05    [W:0.055 / U:6.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site