lkml.org 
[lkml]   [2020]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 5/5] iio: adc: ad7793: use read_avail iio hook for scale available
On Sun, 22 Mar 2020 09:18:13 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sat, 2020-03-21 at 21:37 +0200, Andy Shevchenko wrote:
> > [External]
> >
> > On Sat, Mar 21, 2020 at 11:08:02AM +0200, Alexandru Ardelean wrote:
> > > This change uses the read_avail and '.info_mask_shared_by_type_available'
> > > modifier to set the available scale.
> > > Essentially, nothing changes to the driver's ABI.
> > >
> > > The main idea for this patch is to remove the AD7793 driver from
> > > checkpatch's radar. There have been about ~3 attempts to fix/break the
> > > 'in_voltage-voltage_scale_available' attribute, because checkpatch assumed
> > > it to be an arithmetic operation and people were trying to change that.
> > > +static int ad7793_read_avail(struct iio_dev *indio_dev,
> > > + struct iio_chan_spec const *chan,
> > > + const int **vals, int *type, int *length,
> > > + long mask)
> > > {
> > > struct ad7793_state *st = iio_priv(indio_dev);
> > >
> > > + switch (mask) {
> > > + case IIO_CHAN_INFO_SCALE:
> > > + *vals = (int *)st->scale_avail;
> > > + *type = IIO_VAL_INT_PLUS_NANO;
> > > + /* Values are stored in a 2D matrix */
> > > + *length = ARRAY_SIZE(st->scale_avail) * 2;
> > >
> > > + return IIO_AVAIL_LIST;
> > > + }
> > >
> > > + return -EINVAL;
> >
> > Wouldn't be better move this under default case?
> >
>
> Ummm, sure.
> I'm a bit vague how we do from here since Jonathan accepted this and the
> patchset.
> I'll send a V3 of the whole set [in a few days max].

I'll drop this last patch. Just resend this one with the change.

Jonathan

\
 
 \ /
  Last update: 2020-03-22 16:16    [W:0.061 / U:5.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site