lkml.org 
[lkml]   [2020]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: iio: Drop unnecessary explicit casting
From
Date
On Sat, 2020-03-21 at 23:56 +0530, Nishant Malpani wrote:
> On 21/03/20 5:56 pm, Joe Perches wrote:
> > On Wed, 2020-03-18 at 15:37 +0530, Nishant Malpani wrote:
> > > Provide correct specifiers while printing error logs to discard the use
> > > of unnecessary explicit casting.
> > []
> > > diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
> > []
> > > @@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c,
> > >
> > > regmap = devm_regmap_init_i2c(i2c, &config);
> > > if (IS_ERR(regmap)) {
> > > - dev_err(&i2c->dev, "Failed to register i2c regmap %d\n",
> > > - (int)PTR_ERR(regmap));
> > > + dev_err(&i2c->dev, "Failed to register i2c regmap %ld\n",
> > > + PTR_ERR(regmap));
> >
> > Another option would be to use %pe to print the error identifier
> > and not the error number
> >
> By 'error identifier' you mean the symbolic error name (as described in
> docs [1]), right?

Yes

> https://www.kernel.org/doc/html/latest/core-api/printk-formats.html#error-pointers


\
 
 \ /
  Last update: 2020-03-21 19:36    [W:0.076 / U:6.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site