lkml.org 
[lkml]   [2020]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] iio: light: tsl2563: Wrap comment description
From
Date
On 21/03/20 5:21 pm, Joe Perches wrote:
> On Wed, 2020-03-18 at 13:33 +0530, Nishant Malpani wrote:
>> This patch wraps the comment description at 75 chars. Fixes the
>> following warning generated by checkpatch.pl:
>>
>> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
>
> Please do not scan files as patches.
>
> checkpatch does not emit this message on a file
> when used properly with the -f option.
>
You're right, Joe. I had used checkpatch.pl without the -f option on a
file, ergo giving me the aforementioned warning. My bad, I shall refrain
from not doing this in the future. Thank you and Jonathan for correcting me.

With regards,
Nishant Malpani

>> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
> []
>> @@ -222,9 +222,9 @@ static int tsl2563_read_id(struct tsl2563_chip *chip, u8 *id)
>> }
>>
>> /*
>> - * "Normalized" ADC value is one obtained with 400ms of integration time and
>> - * 16x gain. This function returns the number of bits of shift needed to
>> - * convert between normalized values and HW values obtained using given
>> + * "Normalized" ADC value is one obtained with 400ms of integration time
>> + * and 16x gain. This function returns the number of bits of shift needed
>> + * to convert between normalized values and HW values obtained using given
>> * timing and gain settings.
>> */
>> static int tsl2563_adc_shiftbits(u8 timing)
>

\
 
 \ /
  Last update: 2020-03-21 14:10    [W:0.049 / U:13.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site