Messages in this thread | | | Subject | Re: [PATCH] bpf: explicitly memset the bpf_attr structure | From | Daniel Borkmann <> | Date | Fri, 20 Mar 2020 21:07:24 +0100 |
| |
On 3/20/20 10:48 AM, Greg Kroah-Hartman wrote: > For the bpf syscall, we are relying on the compiler to properly zero out > the bpf_attr union that we copy userspace data into. Unfortunately that > doesn't always work properly, padding and other oddities might not be > correctly zeroed, and in some tests odd things have been found when the > stack is pre-initialized to other values. > > Fix this by explicitly memsetting the structure to 0 before using it. > > Reported-by: Maciej Żenczykowski <maze@google.com> > Reported-by: John Stultz <john.stultz@linaro.org> > Reported-by: Alexander Potapenko <glider@google.com> > Reported-by: Alistair Delva <adelva@google.com> > Cc: stable <stable@vger.kernel.org> > Link: https://android-review.googlesource.com/c/kernel/common/+/1235490 > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Applied, thanks!
| |