lkml.org 
[lkml]   [2020]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] soundwire: stream: only change state if needed
From
Date


On 3/20/20 9:15 AM, Vinod Koul wrote:
> On 17-03-20, 05:51, Pierre-Louis Bossart wrote:
>> In a multi-cpu DAI context, the stream routines may be called from
>> multiple DAI callbacks. Make sure the stream state only changes for
>> the first call, and don't return error messages if the target state is
>> already reached.
>
> For stream-apis we have documented explicitly in Documentation/driver-api/soundwire/stream.rst
>
> "Bus implements below API for allocate a stream which needs to be called once
> per stream. From ASoC DPCM framework, this stream state maybe linked to
> .startup() operation.
>
> .. code-block:: c
>
> int sdw_alloc_stream(char * stream_name); "
>
> This is documented for all stream-apis.
>
> This can be resolved by moving the calling of these APIs from
> master-dais/slave-dais to machine-dais. They are unique in the card.

this change is about prepare/enable/disable/deprepare, not allocation or
startup.

I see no reason to burden the machine driver with all these steps. It's
not because QCOM needs this transition that everyone does.

As discussed earlier, QCOM cannot use this functionality because the
prepare/enable and disable/deprepare are done in the hw_params and
hw_free respectively. This was never the intended use, but Intel let it
happen so I'd like you to return the favor. This change has no impact
for QCOM and simplifies the Intel solution, so why would you object?

Seriously, your replies on all Intel contributions make me wonder if
this is the QCOM/Linaro SoundWire subsystem, or if we are going to find
common ground to deal with vastly different underlying architectures?

\
 
 \ /
  Last update: 2020-03-20 19:18    [W:0.091 / U:1.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site