lkml.org 
[lkml]   [2020]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mm/dmapool.c: micro-optimisation remove unnecessary branch
Date
From: Mateusz Nosek <mateusznosek0@gmail.com>

Previously there was a check if 'size' is aligned to 'align' and if not
then it was aligned. This check was expensive as both branch and division
are expensive instructions in most architectures.
'ALIGN' function on already aligned value will not change it, and as it is
cheaper than branch + division it can be executed all the time and
branch can be removed.

Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
---
mm/dmapool.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index fe5d33060415..f9fb9bbd733e 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -144,9 +144,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
else if (size < 4)
size = 4;

- if ((size % align) != 0)
- size = ALIGN(size, align);
-
+ size = ALIGN(size, align);
allocation = max_t(size_t, size, PAGE_SIZE);

if (!boundary)
--
2.17.1
\
 
 \ /
  Last update: 2020-03-20 18:35    [W:0.032 / U:41.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site