lkml.org 
[lkml]   [2020]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH -next] PCI: dwc: fix compile err for pcie-tagra194
From
Date


On 3/19/2020 11:07 PM, Lorenzo Pieralisi wrote:
> External email: Use caution opening links or attachments
>
>
> On Thu, Mar 19, 2020 at 08:36:20PM +0800, Qiujun Huang wrote:
>> make allmodconfig
>> ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
>> ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
>> ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
>> make[2]: *** [__modpost] Error 1
>> make[1]: *** [modules] Error 2
>> make: *** [sub-make] Error 2
>>
>> need to export the symbols.
>>
>> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
>> ---
>> drivers/pci/controller/dwc/pcie-designware-ep.c | 3 +++
>> 1 file changed, 3 insertions(+)
>
> I have squashed this in with the original patch.
>
> @Vidya: is this something we missed in the review cycle ? Asking just
> to make sure it was not me who made a mistake while merging the code.
My apologies. I wasn't compiling the driver as a module (instead built
into the kernel image)
BTW, I see
ERROR: modpost: "dw_pcie_ep_init"
[drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
also along with the above three. So I think even dw_pcie_ep_init() needs
to be exported.

Thanks,
Vidya Sagar
>
> Thanks,
> Lorenzo
>
>> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
>> index 4233c43..60d62ef 100644
>> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
>> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
>> @@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)
>>
>> pci_epc_linkup(epc);
>> }
>> +EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup);
>>
>> void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
>> {
>> @@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
>>
>> pci_epc_init_notify(epc);
>> }
>> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify);
>>
>> static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar,
>> int flags)
>> @@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)
>>
>> return 0;
>> }
>> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_complete);
>>
>> int dw_pcie_ep_init(struct dw_pcie_ep *ep)
>> {
>> --
>> 1.8.3.1
>>

\
 
 \ /
  Last update: 2020-03-20 06:16    [W:0.437 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site