lkml.org 
[lkml]   [2020]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] staging: rtl8192u: Corrects 'Avoid CamelCase' for variables
On Wed, Mar 18, 2020 at 02:31:27PM -0300, Camylla Cantanheide wrote:
> Dear Dan Carpenter and Joe Perches,
>
> Thank you very much for the suggestions, I found the evaluation of both
> very significant. Now, I have another perspective on variables.
>
> I solved the problem for the *setKey *function, however, when executing the
> checkpatch, more *Checks* of the same type appeared.

If your changed introduces more warnings then you should fix them. Like
say you rename variables and now the line goes over 80 characters, then
fix the new 80 character warning. But if it was already over 80
characters then ignore the warning.

>
> Should I send the second version of the patch, only to the *setKey*
> function or do I resolve all *Checks* for the entire file?

We want patches which are easy to review. If you change everything in
the file, it will probably be too complicated for me to review. So I
guess ignore those warnings.

regards,
dan carpenter

\
 
 \ /
  Last update: 2020-03-20 12:05    [W:0.067 / U:1.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site