lkml.org 
[lkml]   [2020]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 09/22] cpufreq: Convert to new X86 CPU match macros
Date
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> On Fri, Mar 20, 2020 at 3:18 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
>> + X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 6, 9, X86_FEATURE_EST, NULL),
>> + X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 6, 13, X86_FEATURE_EST, NULL),
>> + X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 15, 3, X86_FEATURE_EST, NULL),
>> + X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 15, 4, X86_FEATURE_EST, NULL),
>
>> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, 0x8, 0),
>> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, 0xb, 0),
>> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 15, 0x2, 0),
>
>> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, 0x8, 0),
>> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, 0xb, 0),
>> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 15, 0x2, 0),
>
> Perhaps use names instead of 6 and 15?

Thought about that and did not come up with anyting useful. FAM6 vs. 6
is not really any better

> Also, NULL vs. 0?

Both works, but yes I used mostly NULL.

Thanks,

tglx

\
 
 \ /
  Last update: 2020-03-20 21:31    [W:0.312 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site