lkml.org 
[lkml]   [2020]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] media: staging: tegra-vde: Use devm_platform_ioremap_resource_byname()
From
Date
02.03.2020 11:04, Dan Carpenter пишет:
> On Thu, Feb 27, 2020 at 09:09:15PM +0300, Dmitry Osipenko wrote:
>> This helps to make code cleaner a tad.
>
> Please don't start the commit message in the middle of a sentence.

Could you please clarify what do you mean by the "middle of a sentence"?
The commit's message doesn't sound "middle" to me at all.

> It looks like this for some of us:
>
> https://marc.info/?l=linux-driver-devel&m=158282701430176&w=2

This link points to this patch, I don't quite understand what you're
trying to convey here.

> I generally read the subject or the full commit message but seldom
> both.

The commit's title describes the change briefly, while the message gives
a rational for the change. Usually reviewer should consult the code
changes themselves for more details.

Do you have some kind of a email filter that shows only the commit's
message? Otherwise I'm not sure what's the problem.

> Otherwise the patch looks very good.

Thanks

\
 
 \ /
  Last update: 2020-03-02 16:05    [W:0.050 / U:7.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site