Messages in this thread | | | Subject | Re: misc nits Re: [PATCH 1/2] printk: add lockless buffer | From | Joe Perches <> | Date | Mon, 02 Mar 2020 04:17:18 -0800 |
| |
On Mon, 2020-03-02 at 11:38 +0100, John Ogness wrote: > On 2020-02-21, Petr Mladek <pmladek@suse.com> wrote: > > > diff --git a/kernel/printk/printk_ringbuffer.c b/kernel/printk/printk_ringbuffer.c [] > > > +static struct prb_data_block *to_block(struct prb_data_ring *data_ring, > > > + unsigned long begin_lpos) > > > +{ > > > + char *data = &data_ring->data[DATA_INDEX(data_ring, begin_lpos)]; > > > + > > > + return (struct prb_data_block *)data; > > > > Nit: Please, use "blk" instead of "data". I was slightly confused > > because "data" is also one member of struct prb_data_block. > > OK.
trivia:
Perhaps use void * instead of char * and a direct return and avoid the naming altogether.
static struct prb_data_block *to_block(struct prb_data_ring *data_ring, unsigned long begin_lpos) { return (void *)&data_ring->data[DATA_INDEX(data_ring, begin_lpos)]; }
| |