lkml.org 
[lkml]   [2020]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: rawnand: ingenic: Fix unmet dependency if COMPILE_TEST
Hi Paul,

Paul Cercueil <paul@crapouillou.net> wrote on Sat, 29 Feb 2020 13:04:43
-0300:

> Commit 7c779cf7c1f7 ("mtd: rawnand: ingenic: Allow to compile test the
> new Ingenic driver") dropped the dependency on JZ4780_NEMC when
> COMPILE_TEST was set, which is wrong, as the driver requires symbols
> provided by the jz4780-nemc driver.
>
> Change the dependency to (MIPS || COMPILE_TEST) && JZ4780_NEMC to
> address the issue.

That was simple actually, thanks for finding the solution. Actually I
don't think I mergeg my own patch as it was creating this build issue
(unless I messed with something :) ) so can you please send a patch
just adding COMPILE_TEST support without any Fixes mention?

>
> Fixes: 7c779cf7c1f7 ("mtd: rawnand: ingenic: Allow to compile test the new Ingenic driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/mtd/nand/raw/ingenic/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/ingenic/Kconfig b/drivers/mtd/nand/raw/ingenic/Kconfig
> index 485abfa3f80b..96c5ae8b1bbc 100644
> --- a/drivers/mtd/nand/raw/ingenic/Kconfig
> +++ b/drivers/mtd/nand/raw/ingenic/Kconfig
> @@ -1,7 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config MTD_NAND_JZ4780
> tristate "JZ4780 NAND controller"
> - depends on JZ4780_NEMC || COMPILE_TEST
> + depends on MIPS || COMPILE_TEST
> + depends on JZ4780_NEMC
> help
> Enables support for NAND Flash connected to the NEMC on JZ4780 SoC
> based boards, using the BCH controller for hardware error correction.

Thanks,
Miquèl

\
 
 \ /
  Last update: 2020-03-02 10:27    [W:0.041 / U:14.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site