Messages in this thread | | | Date | Mon, 2 Mar 2020 10:01:31 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH V2] thermal: imx_thermal: Use __maybe_unused instead of CONFIG_PM_SLEEP |
| |
On Mon, Mar 02, 2020 at 09:54:34AM +0100, Daniel Lezcano wrote: > On 02/03/2020 09:26, Anson Huang wrote: > > Hi, Uwe > > > > > >> Subject: Re: [PATCH V2] thermal: imx_thermal: Use __maybe_unused instead > >> of CONFIG_PM_SLEEP > >> > >> On Mon, Mar 02, 2020 at 03:50:10PM +0800, Anson Huang wrote: > >>> Use __maybe_unused for power management related functions instead of > >>> #if CONFIG_PM_SLEEP to simplify the code. > >>> > >>> Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > >>> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > >> > >> IMHO translating my "otherwise looks fine" in a "Reviewed-by" is a bit bold. > >> Please don't assume this. > > > > OK, will keep it in mind next time, thanks. > > When applying a patch, now we add the link to the lkml archive > automatically. I can't apply this patch if the Reviewed-by is not accepted. > > Or the Reviewed-by tag is confirmed or a V3 without the Reviewed-by must > be resent.
I didn't look close enough to justify a Reviewed-by:, so "the Reviewed-by tag is confirmed" is ruled out.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
| |