lkml.org 
[lkml]   [2020]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2] thermal: imx_thermal: Use __maybe_unused instead of CONFIG_PM_SLEEP
Date
Hi, Uwe


> Subject: Re: [PATCH V2] thermal: imx_thermal: Use __maybe_unused instead
> of CONFIG_PM_SLEEP
>
> On Mon, Mar 02, 2020 at 03:50:10PM +0800, Anson Huang wrote:
> > Use __maybe_unused for power management related functions instead of
> > #if CONFIG_PM_SLEEP to simplify the code.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> IMHO translating my "otherwise looks fine" in a "Reviewed-by" is a bit bold.
> Please don't assume this.

OK, will keep it in mind next time, thanks.

Anson
\
 
 \ /
  Last update: 2020-03-02 09:26    [W:0.069 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site