lkml.org 
[lkml]   [2020]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] media: staging: tegra-vde: Use devm_platform_ioremap_resource_byname()
On Thu, Feb 27, 2020 at 09:09:15PM +0300, Dmitry Osipenko wrote:
> This helps to make code cleaner a tad.

Please don't start the commit message in the middle of a sentence.
It looks like this for some of us:

https://marc.info/?l=linux-driver-devel&m=158282701430176&w=2

I generally read the subject or the full commit message but seldom
both.

Otherwise the patch looks very good.

regards,
dan carpenter

\
 
 \ /
  Last update: 2020-03-02 09:05    [W:0.076 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site