lkml.org 
[lkml]   [2020]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 7/8] ASoC: dt-bindings: fsl_easrc: Add document for EASRC
    On Sun, Mar 01, 2020 at 01:24:18PM +0800, Shengjiu Wang wrote:
    > EASRC (Enhanced Asynchronous Sample Rate Converter) is a new
    > IP module found on i.MX8MN.
    >
    > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
    > ---
    > .../devicetree/bindings/sound/fsl,easrc.yaml | 96 +++++++++++++++++++
    > 1 file changed, 96 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/sound/fsl,easrc.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
    > new file mode 100644
    > index 000000000000..500af8f0c8f0
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
    > @@ -0,0 +1,96 @@
    > +# SPDX-License-Identifier: GPL-2.0

    Dual license new bindings:

    (GPL-2.0-only OR BSD-2-Clause)

    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/sound/fsl,easrc.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: NXP Asynchronous Sample Rate Converter (ASRC) Controller
    > +
    > +maintainers:
    > + - Shengjiu Wang <shengjiu.wang@nxp.com>
    > +
    > +properties:
    > + $nodename:
    > + pattern: "^easrc@.*"
    > +
    > + compatible:
    > + oneOf:
    > + - items:

    You can drop oneOf and items here.

    > + - enum:
    > + - fsl,imx8mn-easrc

    Blank line between properties please.

    > + reg:
    > + maxItems: 1
    > +
    > + interrupts:
    > + maxItems: 1
    > +
    > + clocks:
    > + items:
    > + - description: Peripheral clock
    > +
    > + clock-names:
    > + items:
    > + - const: mem
    > +
    > + dmas:
    > + maxItems: 8
    > +
    > + dma-names:
    > + oneOf:

    Drop oneOf as there is only one.

    > + - items:
    > + - const: ctx0_rx
    > + - const: ctx0_tx
    > + - const: ctx1_rx
    > + - const: ctx1_tx
    > + - const: ctx2_rx
    > + - const: ctx2_tx
    > + - const: ctx3_rx
    > + - const: ctx3_tx
    > +
    > + fsl,easrc-ram-script-name:
    > + $ref: /schemas/types.yaml#/definitions/string
    > + description: The coefficient table for the filters

    Need to define the exact string(s).

    > +
    > + fsl,asrc-rate:
    > + $ref: /schemas/types.yaml#/definitions/uint32
    > + description: Defines a mutual sample rate used by DPCM Back Ends

    Constraints?

    > +
    > + fsl,asrc-format:
    > + $ref: /schemas/types.yaml#/definitions/uint32
    > + description: Defines a mutual sample format used by DPCM Back Ends

    Constraints?

    > +
    > +required:
    > + - compatible
    > + - reg
    > + - interrupts
    > + - clocks
    > + - clock-names
    > + - dmas
    > + - dma-name

    dma-names

    > + - fsl,easrc-ram-script-name
    > + - fsl,asrc-rate
    > + - fsl,asrc-format
    > +
    > +examples:
    > + - |
    > + #include <dt-bindings/clock/imx8mn-clock.h>
    > +
    > + easrc: easrc@300C0000 {
    > + compatible = "fsl,imx8mn-easrc";
    > + reg = <0x0 0x300C0000 0x0 0x10000>;
    > + interrupts = <0x0 122 0x4>;
    > + clocks = <&clk IMX8MN_CLK_ASRC_ROOT>;
    > + clock-names = "mem";
    > + dmas = <&sdma2 16 23 0> , <&sdma2 17 23 0>,
    > + <&sdma2 18 23 0> , <&sdma2 19 23 0>,
    > + <&sdma2 20 23 0> , <&sdma2 21 23 0>,
    > + <&sdma2 22 23 0> , <&sdma2 23 23 0>;
    > + dma-names = "ctx0_rx", "ctx0_tx",
    > + "ctx1_rx", "ctx1_tx",
    > + "ctx2_rx", "ctx2_tx",
    > + "ctx3_rx", "ctx3_tx";
    > + fsl,easrc-ram-script-name = "imx/easrc/easrc-imx8mn.bin";
    > + fsl,asrc-rate = <8000>;
    > + fsl,asrc-format = <2>;
    > + status = "disabled";

    Don't show status in examples.

    > + };
    > --
    > 2.21.0
    >

    \
     
     \ /
      Last update: 2020-03-03 02:47    [W:2.556 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site