lkml.org 
[lkml]   [2020]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] vt: vt_ioctl: fix VT_DISALLOCATE freeing in-use virtual console
From
Date
On 18. 03. 20, 23:38, Eric Biggers wrote:
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -1102,6 +1102,9 @@ int vc_allocate(unsigned int currcons) /* return 0 on success */
> tty_port_init(&vc->port);
> INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
>
> + /* if this wasn't the case, we'd have to implement port->ops.destruct */
> + BUILD_BUG_ON(offsetof(struct vc_data, port) != 0);
> +

This is 3 lines, implementing destruct would be like 4-5 :)? Please
implement destruct instead.

Otherwise looks good.

thanks,
--
js
suse labs

\
 
 \ /
  Last update: 2020-03-19 08:37    [W:0.129 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site