lkml.org 
[lkml]   [2020]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 01/93] NFS: Remove superfluous kmap in nfs_readdir_xdr_to_array
    Date
    From: Petr Malat <oss@malat.biz>

    Array is mapped by nfs_readdir_get_array(), the further kmap is a result
    of a bad merge and should be removed.

    This resource leakage can be exploited for DoS by receptively reading
    a content of a directory on NFS (e.g. by running ls).

    Fixes: 67a56e9743171 ("NFS: Fix memory leaks and corruption in readdir")
    Signed-off-by: Petr Malat <oss@malat.biz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/nfs/dir.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/fs/nfs/dir.c
    +++ b/fs/nfs/dir.c
    @@ -657,8 +657,6 @@ int nfs_readdir_xdr_to_array(nfs_readdir
    goto out_label_free;
    }

    - array = kmap(page);
    -
    status = nfs_readdir_alloc_pages(pages, array_size);
    if (status < 0)
    goto out_release_array;

    \
     
     \ /
      Last update: 2020-03-19 14:05    [W:2.218 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site