lkml.org 
[lkml]   [2020]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner()
    From
    Date
    On 3/19/20 7:47 AM, Christian Brauner wrote:
    > The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different
    > from the !CONFIG_SYSFS version and thus causes build failurs when
    > !CONFIG_SYSFS is set.
    >
    > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

    Reported-by: Randy Dunlap <rdunlap@infradead.org>
    Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

    > Fixes: 303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()")
    > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

    Thanks.

    > ---
    > include/linux/sysfs.h | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
    > index 9e531ec76274..4beb51009b62 100644
    > --- a/include/linux/sysfs.h
    > +++ b/include/linux/sysfs.h
    > @@ -562,8 +562,8 @@ static inline int sysfs_groups_change_owner(struct kobject *kobj,
    > }
    >
    > static inline int sysfs_group_change_owner(struct kobject *kobj,
    > - const struct attribute_group **groups,
    > - kuid_t kuid, kgid_t kgid)
    > + const struct attribute_group *groups,
    > + kuid_t kuid, kgid_t kgid)
    > {
    > return 0;
    > }
    >
    > base-commit: 79e28519ac78dde6d38fe6ea22286af574f5c7db
    >


    --
    ~Randy

    \
     
     \ /
      Last update: 2020-03-19 17:20    [W:3.134 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site