lkml.org 
[lkml]   [2020]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH] dynamic_debug: Add config option of DYNAMIC_DEBUG_CORE
On Wed, Mar 18, 2020 at 9:04 PM Orson Zhai <orson.unisoc@gmail.com> wrote:
>
> There is the requirement from new Android that kernel image (GKI) and
> kernel modules are supposed to be built at differnet places. Some people
> want to enable dynamic debug for kernel modules only but not for kernel
> image itself with the consideration of binary size increased or more
> memory being used.
>
> By this patch, dynamic debug is divided into core part (the defination of
> functions) and macro replacement part. We can only have the core part to
> be built-in and do not have to activate the debug output from kenrel image.
>

There are few grammar typos in above...

> config DYNAMIC_DEBUG
> bool "Enable dynamic printk() support"
> default n

> - depends on PRINTK
> - depends on DEBUG_FS

You may not touch this. By removing them you effectively removed
dependencies :-(

> + select DYNAMIC_DEBUG_CORE
> help
>
> Compiles debug level messages into the kernel, which would not
> @@ -164,6 +163,21 @@ config DYNAMIC_DEBUG
> See Documentation/admin-guide/dynamic-debug-howto.rst for additional
> information.
>
> +config DYNAMIC_DEBUG_CORE
> + bool "Enable core functions of dynamic debug support"
> + depends on PRINTK
> + depends on DEBUG_FS
> + help
> + Enable this option to build ddebug_* and __dynamic_* routines
> + into kernel. If you want enable whole dynamic debug features,
> + select CONFIG_DYNAMIC_DEBUG directly and this option will be
> + automatically selected.
> +
> + This option is selected when you want to enable dynamic debug

> + for kernel modules only but not for the kernel base. Especailly

Typo.

> + in the case that kernel modules are built out of the place where
> + kernel base is built.

Highly recommend to ask somebody to do proof read.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-03-18 20:24    [W:0.111 / U:7.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site