lkml.org 
[lkml]   [2020]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/5] pci: handled return value of platform_get_irq correctly
    Date
    Bjorn,

    Bjorn Helgaas <helgaas@kernel.org> writes:
    > On Fri, Mar 13, 2020 at 04:56:42PM -0500, Bjorn Helgaas wrote:
    >> On Fri, Mar 13, 2020 at 10:05:58PM +0100, Thomas Gleixner wrote:
    >> > > I think the best pattern is:
    >> > >
    >> > > irq = platform_get_irq(pdev, i);
    >> > > if (irq < 0)
    >> > > return irq;
    >> >
    >> > Careful. 0 is not a valid interrupt.
    >>
    >> Should callers of platform_get_irq() check for a 0 return value?
    >> About 900 of them do not.

    I don't know what I was looking at.

    platform_get_irq() does the right thing already, so checking for irq < 0
    is sufficient.

    Sorry for the confusion!

    Thanks,

    tglx

    \
     
     \ /
      Last update: 2020-03-18 14:43    [W:2.390 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site