Messages in this thread | | | From | Rajan Vaja <> | Subject | RE: [PATCH v3 20/24] firmware: xilinx: Add APIs to read/write GGS/PGGS registers | Date | Wed, 18 Mar 2020 12:41:46 +0000 |
| |
Hi Greg,
Thanks for applying patches and review.
Please see my comment inline.
> -----Original Message----- > From: Greg KH <gregkh@linuxfoundation.org> > Sent: 18 March 2020 05:22 PM > To: Jolly Shah <JOLLYS@xilinx.com> > Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; matt@codeblueprint.co.uk; > sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org; > dmitry.torokhov@gmail.com; Michal Simek <michals@xilinx.com>; Rajan Vaja > <RAJANV@xilinx.com>; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; Rajan Vaja <RAJANV@xilinx.com> > Subject: Re: [PATCH v3 20/24] firmware: xilinx: Add APIs to read/write GGS/PGGS > registers > > CAUTION: This message has originated from an External Source. Please use > proper judgment and caution when opening attachments, clicking links, or > responding to this email. > > > On Fri, Mar 06, 2020 at 03:47:28PM -0800, Jolly Shah wrote: > > --- a/include/linux/firmware/xlnx-zynqmp.h > > +++ b/include/linux/firmware/xlnx-zynqmp.h > > @@ -105,6 +105,10 @@ enum pm_ioctl_id { > > IOCTL_GET_PLL_FRAC_MODE, > > IOCTL_SET_PLL_FRAC_DATA, > > IOCTL_GET_PLL_FRAC_DATA, > > + IOCTL_WRITE_GGS, > > + IOCTL_READ_GGS, > > + IOCTL_WRITE_PGGS, > > + IOCTL_READ_PGGS, > > You do not have explicit numbers here? Bold :) [Rajan] Here new IOCTL IDs are continuous so didn't mention explicit number. Are asking for adding numbers like below: enum pm_ioctl_id { ... IOCTL_GET_PLL_FRAC_DATA = 11, IOCTL_WRITE_GGS = 12, .... }
Thanks, Rajan > greg k-h
| |