lkml.org 
[lkml]   [2020]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 9/9] drm/nouveau/kms/nvd9-: Add CRC support
On Tue, Mar 17, 2020 at 08:41:06PM -0400, Lyude Paul wrote:
> + root = debugfs_create_dir("nv_crc", crtc->debugfs_entry);
> + if (IS_ERR(root))
> + return PTR_ERR(root);

No need to check this, just take the return value and move on.

> +
> + dent = debugfs_create_file("flip_threshold", 0644, root, head,
> + &nv50_crc_flip_threshold_fops);
> + if (IS_ERR(dent))
> + return PTR_ERR(dent);

No need to check this either, in fact this test is incorrect :(

Just make the call, and move on. See the loads of debugfs cleanups I
have been doing for examples.

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-03-18 07:03    [W:1.781 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site